Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: collect separate metrics for root alised services and worker spells [fixes NET-431] #1539

Merged
merged 7 commits into from
Apr 6, 2023

Conversation

kmd-fl
Copy link
Contributor

@kmd-fl kmd-fl commented Mar 29, 2023

Collect separate metrics for:

  • aliased services from root scope
  • worker spells (aka marked as such in aliases)

@kmd-fl kmd-fl requested review from folex and justprosh March 29, 2023 14:46
@linear
Copy link

linear bot commented Mar 29, 2023

NET-431 Collect metrics only for builtin aliased services

Now we collect metrics for all aliased services, which is a lot since we introduced workers.

Need to understand which aliases services to monitor:

  • Only from the "root" scope (aka pre-build services)
  • "worker-spell"

@kmd-fl kmd-fl requested a review from gurinderu April 3, 2023 10:25
@nahsi nahsi added the e2e Run e2e workflow label Apr 3, 2023
@kmd-fl kmd-fl merged commit 270cfd2 into master Apr 6, 2023
@kmd-fl kmd-fl deleted the restrict-metrics-collection branch April 6, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants